Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a brand new implementation of
medium-zoom
without any API changes.This PR adds support for zooms in
overflow: hidden
containers (see #19, @antoinechalifour), but also for images having atransform
property before being zoomed.Before → After
Why
overflow: hidden
containers stayed cropped when zoomed.transform
properties once zoomed.Solution
Clone the image and append it to the
body
so that it's not constraint to its parent or any of its previous properties. This clone needs to be at the exact same position as the original, without anytransform
property.Steps
absolute
positionshow
eventhide
eventNotes
Performance
I originally was concerned about performance, but we can still easily reach more than 60fps.
Animation
Since we duplicate the target image, it can trigger some fancy animations. It's something we need to be aware of.
Preview
View preview
This PR will also make possible the implementation of #6 🎉