Fix suru icon color #106
Closed
Fix suru icon color #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All three icon themes are the Suru icon theme, but to have support for all versions of the Communitheme installation there should be packages for all three.
For Yaru, Suru, Communitheme icon theme All three themes are needed due to a name change for the communitheme snap and the new theme name for ubuntu 18.10 +
|
Merged as [7e14934]. Thanks again! |
|
@franglais125 great thank you! Why did you close it and not merge it? :D maybe I lack some understanding here (really, no irony or something) |
|
I cherry-picked your new commit locally with git (not through github). When I pushed the changes, your code was already in and there was no need to merge this PR. I often work more locally than through this interface! |
|
Ah thanks for clarification =) Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@franglais125 sorry for the mistake, now with the correct color!
Use white for minimize, maximize, close, restore buttons
For Yaru, Suru, Communitheme icon theme
All three themes are needed due to a name change for the communitheme snap and the new theme name for ubuntu 18.10