Fix for twitter style onscroll pagination #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For on scroll pagination. It's not working with win.scroll. I switched it to doc.scroll and it's working fine. Also, I didn't see any reason 'doc' should not be a local variable instead of a global. so put a 'var' in front of it. These changes are working fine for my use case. i.e. twitter style on-scroll pagination.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this issue. The page loads with a show_more link at the end. When show_more link is clicked, it's loading the next page of items via ajax but this doesn't happen automatically as it should be when we set paginateOnScroll:true. StackOverflow Question here