-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed PodSpec #12
Fixed PodSpec #12
Conversation
Thanks to you Matthew, for the contribution and the kind words :) |
My pleasure :). Unfortunately, it seems that tags don't get merged when pull requests are merged (I didn't know that), and that means that CocoaPods won't be able to find your code. So if you don't mind, please also add a
That command assumes that
If, instead of seeing the word
instead of this
then you should add the tag using this command
instead of this command
Apologies if that was long-winded, or if I told you things you already knew. I just want to make the process as painless as possible. Let me know if you have any questions, and sorry to add another step to this process. |
Done. |
So, if a change the version in the podspec file, I also need to update the tag? |
Yes; each time you change the version in the For example, say that you find a bug in FDStatusBarNotifierView. You fix that bug, commit that change, and push it to Github. According to semantic versioning, the versioning system that CocoaPods requires you to use, you have now created a new version of FDStatusBarNotifierView, namely version If you want that version of FDStatusBarNotifierView to be available via CocoaPods, then you need to do the following: Create a git tagCreate a git tag that points to your latest commit (the commit where you fixed the bug), and give that tag a logical name
Push the tag to GithubYou've now created the tag locally, but you need to push it up to Github. To do so, type Update your
|
Hi Francesco,
First off, thanks for the great work on FDStatusBarNotifierView! Thanks also for including a podspec in your repo. Unfortunately, your podspec is not currently a part of the official Specs repository, and when I tried to add it, there were some validation issues with the podspec itself.
I've fixed these issues, and have added a tag to the repo as required by CocoaPods. Please merge this pull request; once you do, I'll be able to publish your podspec to the official Specs repository, and then anyone using CocoaPods can easily find and use your code.
Thanks again for your work on FDStatusBarNotifierView; let me know if you have any questions.
Thanks!
Matthew