Fix duplicate name attribute in AmazonS3Sender (7.7) #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laurens-makel
changed the title
nielsm5
approved these changes
Mar 8, 2023
|
Zit dit ook zo in de 7.8 / master ? zo ja dan moet het daar ook gefixed worden.. |
|
Nee, het is juist al in de 7.8 en master gefixed terwijl het nooit in de 7.7 gefixed is... Zelfde geldt voor deze change: |
nielsm5
approved these changes
Mar 10, 2023
|
Trouwens, de laatste commit aan dit PR zit nog niet in de 7.8, deze is enkel in de master opgenomen en nu in dit PR..... |
|
Ik heb issue #4634 gemaakt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4603