Aspose library upgrade #5640
Merged
Aspose library upgrade #5640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkosternl
approved these changes
Nov 2, 2023
aspose/src/main/java/nl/nn/adapterframework/extensions/aspose/AsposeLicenseLoader.java
Outdated
Show resolved
Hide resolved
| licenseWrapper.loadLicense(inputStream); | ||
| log.info("loaded Aspose [{}] license", library.name()); | ||
| } catch (Exception e) { | ||
| log.error("failed to load Aspose [" + library.name() + "] license", e); |
There was a problem hiding this comment.
log.error("failed to load Aspose [{}] license", library.name(), e);
There was a problem hiding this comment.
Bedankt, over het hoofd gezien!
nielsm5
reviewed
Nov 5, 2023
...va/nl/nn/adapterframework/extensions/aspose/services/conv/impl/CisConversionServiceImpl.java
Outdated
Show resolved
Hide resolved
...l/nn/adapterframework/extensions/aspose/services/conv/impl/convertors/PdfAttachmentUtil.java
Outdated
Show resolved
Hide resolved
.../nl/nn/adapterframework/extensions/aspose/services/conv/impl/convertors/SlidesConvertor.java
Outdated
Show resolved
Hide resolved
aspose/src/main/java/nl/nn/adapterframework/extensions/aspose/services/util/FileUtil.java
Outdated
Show resolved
Hide resolved
Now we have lots of failing tests
… `double` so there is a bit more feedback on how big the image differences are.
Add option to overwrite test-expectations to make it easier to re-calibrate output after updates.
…-xml; update test-specifications.
…s are released per library and we cannot really have one global "Aspose Version". At least this way all versions are together in a single block with link to the repo.
…services/conv/impl/convertors/PdfAttachmentUtil.java Co-authored-by: Niels Meijer <nielsmeijer@hotmail.com>
…services/conv/impl/CisConversionServiceImpl.java Co-authored-by: Niels Meijer <nielsmeijer@hotmail.com>
…slate an error message from Dutch to English.
tnleeuw
force-pushed
the
aspose-library-upgrade
branch
from
18878f6
to
51faa6d
Compare
nielsm5
approved these changes
Nov 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Nov 6, 2023
tnleeuw
added a commit
that referenced
this pull request
Nov 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-apply Aspose version upgrades and changes from @Laurens-makel against master.
This PR includes changes from and supercedes the following PRs:
This PR is against 7.9-release branch.