Add security-constraint to web.xml

[nielsm5]

No description provided.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

63.2% Coverage
0.0% Duplication

The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[Laurens-makel]

Suggested change

	} else {
	} else if(config.getSecurityRoles().isEmpty()) {
	log.info("registering public endpoint with url pattern [{}]", url);
	publicEndpoints.add(url);
	} else {
	log.info("registering private endpoint with url pattern [{}]", url);
	privateEndpoints.add(url);
	}

[Laurens-makel]

is de huidge opzet met in het else block weer een if/else statement echt nodig?

[nielsm5]

De eerste if past de url aan, deze zet hem direct.

[Laurens-makel]

Dat snap, ik geef ook niet de suggestie om de if's te combineren...

Naar mijn idee is het if/else statement in het else block overbodig and kan het als volgt geschreven worden:

if(url.charAt(0) == '!') {
				String publicUrl = url.substring(1);
				log.info("registering public endpoint with url [{}]", publicUrl);
				publicEndpoints.add(publicUrl);
			} else if(config.getSecurityRoles().isEmpty()) {
			    log.info("registering public endpoint with url pattern [{}]", url);
			    publicEndpoints.add(url);
		    } else {
			    log.info("registering private endpoint with url pattern [{}]", url);
			    privateEndpoints.add(url);
		    }	

effectief doet dit hetzelfde...

[nielsm5]

Ik denk dat

boolean isExcludedUrl = url.charAt(0) == '!';
if(isExcludedUrl || config.getSecurityRoles().isEmpty()) {
	String publicUrl = isExcludedUrl ? url.substring(1) : url;
	log.info("registering public endpoint with url [{}]", publicUrl);
	publicEndpoints.add(publicUrl);
} else {
	log.info("registering private endpoint with url pattern [{}]", url);
	privateEndpoints.add(url);
}

dan misschien nog net iets netter is. Ik zal dit in een volgend pr meenemen.