Make MermaidFlowGenerator more resilient to class loading errors #6198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…case dependencies for optional modules are missing from classpath.
…oaded for any reason.
|
@nielsm5 I added some tests in a separate commit. If you do not like those changes, it's best I have to adding a unit test for this case. We can revert that commit but keep the actual fixes. :-) |
Closed
jacodg
approved these changes
Jan 31, 2024
jkosternl
approved these changes
Feb 1, 2024
core/src/main/java/org/frankframework/util/flow/MermaidFlowGenerator.java
Show resolved
Hide resolved
core/src/test/java/org/frankframework/configuration/digester/TestAnnotationUtils.java
Outdated
Show resolved
Hide resolved
|
nielsm5
approved these changes
Feb 1, 2024
nielsm5
deleted the
issue/6197_ImproveResilienceOfMermaidFlowGenerator
branch
tnleeuw
added a commit
that referenced
this pull request
Feb 1, 2024
(cherry picked from commit b790ffe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might have a test for this too but it requires changing the scanner to also allow scanning classes on the test classpath and I need to verify that there are no negative side-effects on other tests.