Add ReconnectSenderWrapper #6338
Conversation
core/src/main/java/org/frankframework/senders/RuntimeSenderWrapper.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/frankframework/senders/RuntimeSenderWrapper.java
Outdated
Show resolved
Hide resolved
Co-authored-by: J. Koster <j.koster@gmx.com>
core/src/main/java/org/frankframework/senders/RuntimeSenderWrapper.java
Outdated
Show resolved
Hide resolved
| * | ||
| * @author Niels Meijer | ||
| */ | ||
| public class RuntimeSenderWrapper extends SenderWrapperBase { |
There was a problem hiding this comment.
I don't like the name because it doesn't tell you what it does, but I don't have a better name yet.
OpenOnDemandSenderWrapper?ConnectOnDemandSenderWrapper?RuntimeOpenSenderWrapper?DynamicOpenSenderWrapper?
There was a problem hiding this comment.
Yes, I agree with you. I like this one the best ConnectOnDemandSenderWrapper or what about OpenCloseSenderWrapper? That's exactly what happens. Perhaps let Sena validate it, since she is exactly a person who directly needs to understand it.
There was a problem hiding this comment.
@nielsm5 What do you think of these naming suggestions?
ConnectOnDemandSenderWrapper is the best name I can come up with I think.
There was a problem hiding this comment.
ReconnectingSenderWrapper
core/src/main/java/org/frankframework/senders/RuntimeSenderWrapper.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/frankframework/senders/RuntimeSenderWrapper.java
Outdated
Show resolved
Hide resolved
…pper.java Co-authored-by: Tim van der Leeuw <tnleeuw@gmail.com>
I'll quickly interview some people.. So far I'm not convinced yet. (At least the documentation/implementation is ok now) |
I'm also not sure either of these suggestions if really right but to me they're better than |
|
(cherry picked from commit cafd86f)
No description provided.