Add FtpFileSystemActorTest and improve FTP implementation (#6317) #6345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 35b2ba9)
tnleeuw
approved these changes
Feb 23, 2024
nielsm5
reviewed
Feb 23, 2024
Comment on lines
+35
to
+40
| @BeforeAll | ||
| public static void setUpOnce() throws Exception { | ||
| if ("localhost".equals(host)) { | ||
| fs.startServer(FileSystemType.FTP); | ||
| } | ||
| } |
There was a problem hiding this comment.
Denk inderdaad dat je gelijk hebt, vanwege een check die later volgt om te zien of hij al al draait. Zal het binnenkort er wel weer uit halen dan.
nielsm5
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 35b2ba9)