Rename jdbc minPoolSize to minIdle #6347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make name of configuration property clearer and make it more clear that BTM specific options only apply to XA datasource connection pools. * Revert old name `transactionmanager.narayana.jdbc.connection.minPoolSize` for `transactionmanager.narayana.jdbc.connection.minIdle`.
nielsm5
approved these changes
Feb 23, 2024
|
jkosternl
reviewed
Feb 23, 2024
| @@ -115,8 +115,12 @@ jdbc.required=true | |||
| jdbc.datasource.default=jdbc/${instance.name.lc} | |||
|
|
|||
| ## JDBC Connection Pool properties | |||
| # Minimum number of physical connections to maintain. | |||
| # Deprecated, use instead `transactionmanager.jdbc.connection.minIdle` | |||
There was a problem hiding this comment.
Shouldn't we remove the deprecated option from 8.1 because we already marked it as deprecated in 7.9/8.0 and people are still going to migrate to that version still?
There was a problem hiding this comment.
Regardless when people migrate to newer versions, it's deprecated in this one, thus the tag should be there?
There was a problem hiding this comment.
Ok, we'll leave it for 8.1 like this.
jkosternl
requested changes
Feb 23, 2024
jkosternl
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transactionmanager.narayana.jdbc.connection.minPoolSizefortransactionmanager.narayana.jdbc.connection.minIdle.