Support multiple Credential factories #6354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkosternl
changed the title
tnleeuw
requested changes
Feb 26, 2024
credentialProvider/src/main/java/org/frankframework/credentialprovider/CredentialFactory.java
Outdated
Show resolved
Hide resolved
credentialProvider/src/main/java/org/frankframework/credentialprovider/CredentialFactory.java
Outdated
Show resolved
Hide resolved
credentialProvider/src/main/java/org/frankframework/credentialprovider/CredentialFactory.java
Outdated
Show resolved
Hide resolved
credentialProvider/src/main/java/org/frankframework/credentialprovider/CredentialFactory.java
Outdated
Show resolved
Hide resolved
tnleeuw
approved these changes
Feb 26, 2024
nielsm5
reviewed
Feb 27, 2024
| assertEquals("[alias1, account, alias2, TheMaster, TheBachelor]", CredentialFactory.getConfiguredAliases().toString()); | ||
| assertTrue(CredentialFactory.hasCredential("TheMaster")); | ||
| assertTrue(CredentialFactory.hasCredential("fakePrefix:TheBachelor")); | ||
|
|
There was a problem hiding this comment.
Can you add a test to see what happens when you have 2 CredentialFactories with the same alias?
There was a problem hiding this comment.
I think it was already covered by checking account which was in both Factories. But I've added some more accounts and data to validate it really works. Also added the check on password-only credential.
nielsm5
approved these changes
Feb 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests are processed in the order of how the credential factories are specified.
Please verify in the unit tests if I understood every right.