Rename TestTool to LarvaTool, to be more specific #6378
Conversation
jkosternl
commented
Feb 28, 2024
jkosternl
commented
- and be less confusing since Ladybug is a TestTool too
* and be less confusing since Ladybug is a TestTool too
| @@ -3,7 +3,7 @@ scenario.active=${active.fxf} | |||
|
|
|||
| include = ../fxf.properties | |||
|
|
|||
| fxffs.test.className=org.frankframework.testtool.FileSender | |||
| fxffs.test.className=org.frankframework.larva.FileSender | |||
There was a problem hiding this comment.
Ouch, I forgot about this.
This breaks backwards compatibility with existing test-scenarios that users have.
For the package-renaming of 8.0 we made a "fix" for this in the Larva property loader. I'm afraid we'll need to extend that, so that it also rewrites property-values starting with "org.frankframework.testtool" or "nl.nn.adapterframework.testtool" into org.frankframework.larva -- see the method rewriteClassName() in the Larva class!
There was a problem hiding this comment.
Ah yes, I didn't think about others having Larva tests too. I'll add that to that method.
There was a problem hiding this comment.
Done, quicker than I thought 👍🏻 Hopefully this is Ok.
There was a problem hiding this comment.
Is it possible to revert some properties so we can test/ensure this works?
There was a problem hiding this comment.
Is it possible to revert some properties so we can test/ensure this works?
Dat was volgens mij in deze commit gedaan:
There was a problem hiding this comment.
True, in the Base64Pipe.
@nielsm5, if the rest is Ok, can you merge it? When I have some tussenuurtjes Monday, I can do a next refactor piece on the Larva code base.
There was a problem hiding this comment.
Ah, yea sorry... You don't see reverted changes in the pr overview 😶🌫️
There was a problem hiding this comment.
Ah yes, of course, no problem. Thanks for merging 👍🏻
* apply other feedback on PR from Tim
core/src/main/java/org/frankframework/configuration/ClassNameRewriter.java
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
@jkosternl Can you please take a look at this file? It looks to be an empty file, even in 7.9 already!
There was a problem hiding this comment.
Sure, will do that next week, in a next PR in the Larva space.. I have some upcoming improvements/refactors to go 😉
There was a problem hiding this comment.
The file appears to have been committed as empty file in 2019 as part of a large PR, and have lived on unchanged since then... 😬
No haste in removing it!
