Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass "manual retry" flag to sub-adapter to bypass history-checking #6410

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

tnleeuw
Copy link
Contributor

@tnleeuw tnleeuw commented Mar 5, 2024

No description provided.

@@ -55,6 +55,7 @@ public class PipeLineSession extends HashMap<String,Object> implements AutoClose
public static final String MESSAGE_ID_KEY = "mid"; // externally determined (or generated) messageId, e.g. JmsMessageID, HTTP header configured as messageId
public static final String CORRELATION_ID_KEY = "cid"; // conversationId, e.g. JmsCorrelationID.
public static final String STORAGE_ID_KEY = "key";
public static final String MANUAL_RETRY_KEY = "_isManualRetry";
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moet deze niet dubbel underscore geprefixed zijn: PipeLineSession.SYSTEM_MANAGED_RESOURCE_PREFIX.
Hij is niet closeable maar dan kunnen we hem wel 'afschermen' voor een gebruiker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik zat daarover te twijfelen, het is geen resource daarom deed ik het niet.
Ik zal het aanpassen.

Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@nielsm5 nielsm5 merged commit 3a6dc18 into master Mar 6, 2024
14 of 16 checks passed
@nielsm5 nielsm5 deleted the issue/5699_ManualRetrySubAdapterFix branch March 6, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages to sub adapter are rejected when messages are retried from jdbc table listener error storage
3 participants