-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ibisstore fix table columns & link to store #6457
Ibisstore fix table columns & link to store #6457
Conversation
Unit tests run in java 11 on jenkins, instead of java 16 which is when |
Sounds like a Jenkins thing to me ;) |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Thanks Sonar but I'm not rewriting the whole class for a simple addition |
<tr *ngFor="let s of t.slots; let first = first"> | ||
<ng-container *ngIf="first; else notFirstSlot"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Voor de volgende keer 😄
<tr *ngFor="let s of t.slots; let first = first"> | |
<ng-container *ngIf="first; else notFirstSlot"> | |
<tr *ngFor="let s of t.slots; let firstElement = first"> | |
<ng-container *ngIf="firstElement; else notFirstSlot"> |
Improves ibisstore table columns logic & adds configuration to the api response so table can correctly link to the right store (was undefined in frontend before)