Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibisstore fix table columns & link to store #6457

Conversation

Matthbo
Copy link
Sponsor Member

@Matthbo Matthbo commented Mar 15, 2024

Improves ibisstore table columns logic & adds configuration to the api response so table can correctly link to the right store (was undefined in frontend before)

@Matthbo Matthbo self-assigned this Mar 15, 2024
@Matthbo Matthbo linked an issue Mar 15, 2024 that may be closed by this pull request
@Matthbo
Copy link
Sponsor Member Author

Matthbo commented Mar 15, 2024

Unit tests run in java 11 on jenkins, instead of java 16 which is when record class type was added.
I guess I should convert it back to a class to comply with java 11 code

@nielsm5
Copy link
Sponsor Member

nielsm5 commented Mar 16, 2024

Unit tests run in java 11 on jenkins, instead of java 16 which is when record class type was added. I guess I should convert it back to a class to comply with java 11 code

Sounds like a Jenkins thing to me ;)
In this case however, you'll probably need to backport this to the 8.0 and 7.9 branches. So you won't be able to use Record there. It might be easier to keep it all the same for now.

Copy link

sonarcloud bot commented Mar 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Matthbo
Copy link
Sponsor Member Author

Matthbo commented Mar 17, 2024

Thanks Sonar but I'm not rewriting the whole class for a simple addition

Comment on lines +82 to +83
<tr *ngFor="let s of t.slots; let first = first">
<ng-container *ngIf="first; else notFirstSlot">
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voor de volgende keer 😄

Suggested change
<tr *ngFor="let s of t.slots; let first = first">
<ng-container *ngIf="first; else notFirstSlot">
<tr *ngFor="let s of t.slots; let firstElement = first">
<ng-container *ngIf="firstElement; else notFirstSlot">

@philipsens philipsens merged commit f984315 into master Mar 18, 2024
14 of 16 checks passed
@philipsens philipsens deleted the issue/6402-the-ibisstore-summary-is-showing-data-under-the-wrong-column-names branch March 18, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ibisstore summary is showing data under the wrong column names
3 participants