Add log message when pipe is skipped #6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,6 +103,7 @@ protected PipeRunResult processPipe(PipeLine pipeLine, IPipe pipe, Message messa | |||
| if (pipe instanceof FixedForwardPipe) { | |||
| FixedForwardPipe ffPipe = (FixedForwardPipe) pipe; | |||
| if (ffPipe.skipPipe(message, pipeLineSession)) { | |||
| log.info("skipping pipe [{}] because of empty input", pipe::getName); | |||
There was a problem hiding this comment.
Het log statement op deze plek klopt niet helemaal met de controle dat uitgevoerd wordt in de skipPipe methode..
De skip on empty & is not empty check is slechts één van de meerdere redenen waarom deze methode true zou kunnen retourneren..
There was a problem hiding this comment.
Klopt ik zag het ook. Ben er nog niet helemaal over uit of ik een nieuwe processor wil maken of überhaupt de code wil verplaatsen.
Het zit nu iig best raar in elkaar. Voor de 7.9 en 8.0 moeten we denk ik de log regel verplaatsen naar daar waar de checks worden gedaan.
tnleeuw
approved these changes
Apr 2, 2024
jkosternl
approved these changes
Apr 2, 2024
| @@ -385,7 +385,7 @@ | |||
| <dependency> | |||
| <groupId>com.github.mwiede</groupId> | |||
| <artifactId>jsch</artifactId> | |||
| <version>0.2.14</version> | |||
| <version>0.2.15</version> | |||
There was a problem hiding this comment.
Oh, durf je dit hier toch wel aan? Prima op zich. Had het teruggedraaid in mijn PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.