Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ladybug to iaf-test runner and fix add-opens classloading problem #6561

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Add ladybug to iaf-test runner and fix add-opens classloading problem #6561

merged 2 commits into from
Apr 2, 2024

Conversation

nielsm5
Copy link
Sponsor Member

@nielsm5 nielsm5 commented Apr 2, 2024

No description provided.

@nielsm5 nielsm5 linked an issue Apr 2, 2024 that may be closed by this pull request
Console: Reload Configurations leads to NPE "<local2>" is null #6434
Closed
jkosternl
jkosternl approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@jkosternl jkosternl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great find! Good that it fixes my issue. The frank-runner changes can perhaps be reverted then.

@nielsm5
Copy link
Sponsor Member Author

nielsm5 commented Apr 2, 2024

A great find! Good that it fixes my issue. The frank-runner changes can perhaps be reverted then.

We should probably leave those in place for people working on snapshot versions ;)

@jkosternl
Copy link
Contributor

A great find! Good that it fixes my issue. The frank-runner changes can perhaps be reverted then.

We should probably leave those in place for people working on snapshot versions ;)

Yeah, can remove it later as well.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@nielsm5 nielsm5 merged commit a01e781 into master Apr 2, 2024
15 of 16 checks passed
@nielsm5 nielsm5 deleted the feature/enableLadybugAndFixClassAOPLoadingProblems branch April 2, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnleeuw tnleeuw tnleeuw approved these changes

@jkosternl jkosternl jkosternl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console: Reload Configurations leads to NPE "<local2>" is null
3 participants
@nielsm5 @jkosternl @tnleeuw