Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser not going back with back action on logging page #6564

Conversation

philipsens
Copy link
Member

@philipsens philipsens commented Apr 2, 2024

It is still backwards compatible with the old URL's

@philipsens philipsens requested a review from Matthbo April 2, 2024 14:05
@philipsens philipsens linked an issue Apr 2, 2024 that may be closed by this pull request
component: LoggingComponent,
title: 'Logging',
data: {
breadcrumbs: 'Logging > Log Files',
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
breadcrumbs: 'Logging > Log Files',
breadcrumbs: 'Logging > Show Directory (/xyz)',

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be possible by using AppService.customBreadcrumbs(breadcrumbs: string): void in the initialisation of the component, this will overwrite the current breadcrumbs until the user switches to a different page or the function is called again.

component: LoggingComponent,
title: 'Logging',
data: {
breadcrumbs: 'Logging > Log Files',
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
breadcrumbs: 'Logging > Log Files',
breadcrumbs: 'Logging > Show Directory (/name) > Show File (name.png)',

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be possible by using AppService.customBreadcrumbs(breadcrumbs: string): void in the initialisation of the component, this will overwrite the current breadcrumbs until the user switches to a different page or the function is called again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this recommendation. I've implemented it.

@philipsens philipsens requested a review from nielsm5 April 3, 2024 09:48
@philipsens philipsens force-pushed the fix/6563-using-the-native-back-button-on-the-logging-page-wont-go-back branch from d78f4a5 to 47465f8 Compare April 3, 2024 11:16
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nielsm5 nielsm5 merged commit c177760 into master Apr 3, 2024
12 of 14 checks passed
@nielsm5 nielsm5 deleted the fix/6563-using-the-native-back-button-on-the-logging-page-wont-go-back branch April 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the native back button on the logging page won't go back
3 participants