-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix browser not going back with back action on logging page #6564
Fix browser not going back with back action on logging page #6564
Conversation
component: LoggingComponent, | ||
title: 'Logging', | ||
data: { | ||
breadcrumbs: 'Logging > Log Files', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breadcrumbs: 'Logging > Log Files', | |
breadcrumbs: 'Logging > Show Directory (/xyz)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be possible by using AppService.customBreadcrumbs(breadcrumbs: string): void
in the initialisation of the component, this will overwrite the current breadcrumbs until the user switches to a different page or the function is called again.
component: LoggingComponent, | ||
title: 'Logging', | ||
data: { | ||
breadcrumbs: 'Logging > Log Files', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breadcrumbs: 'Logging > Log Files', | |
breadcrumbs: 'Logging > Show Directory (/name) > Show File (name.png)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be possible by using AppService.customBreadcrumbs(breadcrumbs: string): void
in the initialisation of the component, this will overwrite the current breadcrumbs until the user switches to a different page or the function is called again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this recommendation. I've implemented it.
d78f4a5
to
47465f8
Compare
Quality Gate passedIssues Measures |
It is still backwards compatible with the old URL's