Fix insert of ladybug report fails with PostgreSQL #6764
+218
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsm5
reviewed
May 6, 2024
| @@ -117,6 +120,13 @@ private ObjectPool<PoolableConnection> createConnectionPool(PoolableConnectionFa | |||
| } | |||
|
|
|||
| public DataSource getDataSource(String dataSourceName) { | |||
| // File storage will be used instead of database storage when dataSourceName is empty (see | |||
| // springIbisTestTool.xml) but Spring will still wire bean dataSource (calling this method) to bean scheduler | |||
| // (which will ignore it, see SchedulerFactoryBean.setDataSource()). Prevent parent class from throwing an | |||
There was a problem hiding this comment.
In het framework wrappen we dit ding en halen we expliciet de datasource en tx manager setters er uit.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.