Update Apache Tika #6826
Merged
Update Apache Tika #6826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsm5
reviewed
May 15, 2024
nielsm5
approved these changes
May 16, 2024
jkosternl
approved these changes
May 17, 2024
core/pom.xml
Outdated
| @@ -646,7 +646,7 @@ | |||
| <dependency> | |||
| <groupId>org.apache.tika</groupId> | |||
| <artifactId>tika-core</artifactId> | |||
| <version>1.28.5</version> | |||
| <version>2.9.2</version> | |||
| <exclusions> | |||
| <exclusion><!-- excluded because we want to ignore this (1.2.2) version! this dependency handles javax.activation.* imports, and is NOT compatible with the IBM JRE --> | |||
There was a problem hiding this comment.
Are you sure this exclusion is still needed? In the above aspose/pom.xml, you've removed it.
There was a problem hiding this comment.
The comment is a bit out of date, but the version/scope etc are locked in the parent pom.xml 😄
There was a problem hiding this comment.
Yes, but I was just thinking that this library isn't a dependency of the tika-core anymore.
There was a problem hiding this comment.
Good point, I'll remove the comment and exclusion
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade Tika dependency