Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the following changes:
libpthread
on Ubuntu 18.04 so I linklibpthread
inMakefile.in
.getBit
is reverted to the previous version with a slightly more elegant implementation.xi
, which is an off-by-one error, 0 is deliberately assigned toxi
. (This, however, appears to be exhibiting the same behaviour as if you callgetBit(x, 65)
because apparently1lu<<-1 == 0
. But I think it's a good idea to keep this explicit.)fss-test.cpp
is modified to make sure that it is correct witha=2
.