Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: price list #653

Merged
merged 3 commits into from
Jun 6, 2023
Merged

feat: price list #653

merged 3 commits into from
Jun 6, 2023

Conversation

akshayitzme
Copy link
Contributor

@akshayitzme akshayitzme commented Jun 6, 2023

This PR adds the functionality for Price Lists

  • Price List & Item Price (child table) schema

    Enable Price List in General Settings
    Price List page visible only if Price List enabled in General Settings

Functional Details

  1. Price Lists are Filtered in Invoice Form

    • Only Enabled Price Lists will show up in the Invoice Forms.
    • In Sales Invoice Form, Only Price Lists with the Selling option enabled will appear in the Price List Selector.
    • In Purchase Invoice Form, Only Price Lists with the Buying option enabled will appear in the Price List Selector.
      priceList: (doc: Doc) => ({
      enabled: true,
      ...(doc.isSales ? { selling: true } : { buying: true }),
      }),
  2. Price List Enabled For Status

    Status Description
    None Not Enabled any one or both of Buying or Selling
    Buying Price List only Enabled for Buying
    Selling Price List only Enabled for Selling
    Buying & Selling Price List Enabled for both Buying and Selling

@akshayitzme akshayitzme mentioned this pull request Jun 6, 2023
4 tasks
@akshayitzme akshayitzme marked this pull request as ready for review June 6, 2023 09:05
@18alantom
Copy link
Member

PR has several feature design related issues. Irrespective, I'm merging it since all this back and forth is time consuming, and this PR (well the previous price list PRs) have been pending for a while.

Will raise a fix PR soon.

@18alantom 18alantom merged commit 341148e into frappe:master Jun 6, 2023
2 checks passed
@18alantom 18alantom mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants