New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Price List PR #653 #657
Conversation
- update and remove fields
"fieldname": "isSales", | ||
"label": "For Sales", | ||
"fieldtype": "Check", | ||
"default": false, | ||
"required": true | ||
}, | ||
{ | ||
"fieldname": "selling", | ||
"label": "Selling", | ||
"fieldtype": "Check", | ||
"default": false, | ||
"required": true | ||
"default": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why isSales
default value set to true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a better default. Users make Sales more often than Purchases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay got it
], | ||
"quickEditFields": ["item", "unit", "rate"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! FB really needs UI tests 🙈
Simplifies and Fixes #653
Changes:
PriceListItem
fieldsenabled
,buying
,selling
,party
,batch
,validFrom
,validUpto
.PriceList
fieldsisUomDependent
.enabled
,buying,
selling