Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0 valuse in stacked bar #201

Closed
deligent-ant opened this issue Oct 24, 2018 · 2 comments · Fixed by #209
Closed

0 valuse in stacked bar #201

deligent-ant opened this issue Oct 24, 2018 · 2 comments · Fixed by #209
Labels
bug
Milestone
Close 25

Comments

@deligent-ant
Copy link

0 value in stacked bar
even the data is 0 ,therr is alao a line over the bay
image
@deligent-ant
Copy link
Author

const MIN_BAR_PERCENT_HEIGHT = 0 把这个值改成0就可以了

Alchez added a commit to Alchez/charts that referenced this issue Dec 19, 2018
@Alchez
Remove minimum height for zero-values in bar chart
87b68e9 
Fixes frappe#201.

This is really a UX issue.

Previously, if any datapoint was a zero-value, it would still be visible on the chart, making it seem it has non-zero data.

P.S. I wasn't able to run the contribution steps locally, so I have no idea how to rebuild the distribution(s). That might need a separate commit/PR.
@Alchez Alchez mentioned this issue Dec 19, 2018
Merged
@scmmishra scmmishra added the bug label May 24, 2019
@scmmishra scmmishra added this to the Close 30 milestone Jul 20, 2019
@scmmishra
Copy link
Contributor

Fixed here: #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Close 25
Development

Successfully merging a pull request may close this issue.

Remove minimum height for zero-values in bar chart Alchez/charts
2 participants
@scmmishra @deligent-ant