Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security holding package #230

Closed
DanielRuf opened this issue Jun 18, 2019 · 1 comment
Closed

security holding package #230

DanielRuf opened this issue Jun 18, 2019 · 1 comment
Milestone

Comments

@DanielRuf
Copy link

Hi,

it seems you have accidentally added fs but this is not a package on npmjs, fs is an internal NodeJS module.

https://github.com/frappe/charts/blob/master/package.json#L48

See https://nodejs.org/api/fs.html

You might want to remove it using yarn remove fs.

@scmmishra scmmishra added this to the Close 30 milestone Jul 20, 2019
GrosSacASac added a commit to GrosSacASac/charts that referenced this issue Jul 22, 2019
@scmmishra
Copy link
Contributor

Thanks for informing about this. I have removed this module and will be making a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants