Tooltip on scroll container

[renatodeleao]

Heys! Cool lib! while scanning through the demos spotted a small bug on tooltip positioning.
Calculation is wrong when tooltip on scroll container, because parent.offsetWidth < parent.scrollWidth.
demo

Possible Solution (pseudo-code)

Since it's not parent that is scrollable, but some outer wrapper div you could:

1. Add class targeting the scroller ('frappe-chart-outer') or something
2. Check if scroller is scrollable this could be done with

scrollWidth > offsetwith ? isScrollable : notScrollable

1. then use which suits best on calc_position()

this.scroller = 'scrollerEl';
calc_position() {
  ...
  let max_left = (isScrollable? this.scroller.scrollWidth : this.parent.offsetWidth)  - this.container.offsetWidth;
}

As i've stated, this is pseudo code and i haven't tested it. I might try it and submit a PR if you want but probably only have time on Friday.

Cheers and good luck with this!

[achillesrasquinha]

Hi, send in a PR.

[pratu16x7]

@renatodeleao Thanks for reporting! We'll try and fix this asap, but a PR would be wonderful :D