Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to create donut chart #221

Merged
merged 2 commits into from
May 5, 2019

Conversation

ratnajeetshyamkunwar
Copy link
Contributor

@ratnajeetshyamkunwar ratnajeetshyamkunwar commented Apr 9, 2019

Explanation About What Code Achieves:
  • Provides the ability to create Donut charts
Screenshots/GIFs:

Screen Shot 2019-04-09 at 9 10 49 PM

Steps To Test:
  • Import Charts
  • specify type as donut
TODOs:
  • None

@coveralls
Copy link

Pull Request Test Coverage Report for Build 78

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.158%

Totals Coverage Status
Change from base Build 71: 0.0%
Covered Lines: 29
Relevant Lines: 62

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 9, 2019

Pull Request Test Coverage Report for Build 79

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.158%

Totals Coverage Status
Change from base Build 71: 0.0%
Covered Lines: 29
Relevant Lines: 62

💛 - Coveralls

Copy link
Contributor

@scmmishra scmmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've suggested some code improvements, regarding formatting. The logic seems to be fine.

src/js/charts/DonutChart.js Outdated Show resolved Hide resolved
src/js/charts/DonutChart.js Outdated Show resolved Hide resolved
src/js/utils/draw.js Show resolved Hide resolved
Code quality fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants