Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shopify): ability to generate invoice on fulfilment/order creation #228

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Jan 25, 2023

Changes from this PR:

  1. Each fulfillment will create individual sales invoices (required in case of COD).
  2. Recalculates taxes table in Delivery Note.
  3. Clubbed Payment Entry for all related invoices.
Peek.2023-01-25.18-08.mp4

@rtdany10 rtdany10 requested a review from ankush as a code owner January 25, 2023 13:14
@rtdany10 rtdany10 changed the title feat(shopify): ability to generate invoice on fulfilment feat(shopify): ability to generate invoice on fulfilment/order creation Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #228 (921e77c) into develop (1cbdf6b) will decrease coverage by 0.33%.
The diff coverage is 0.00%.

❗ Current head 921e77c differs from pull request most recent head 9c531ac. Consider uploading reports for the commit 9c531ac to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #228      +/-   ##
===========================================
- Coverage    40.95%   40.63%   -0.33%     
===========================================
  Files           62       62              
  Lines         4244     4280      +36     
===========================================
+ Hits          1738     1739       +1     
- Misses        2506     2541      +35     
Impacted Files Coverage Δ
ecommerce_integrations/shopify/fulfillment.py 0.00% <0.00%> (ø)
ecommerce_integrations/shopify/invoice.py 0.00% <0.00%> (ø)
ecommerce_integrations/shopify/order.py 15.55% <0.00%> (-0.18%) ⬇️
ecommerce_integrations/shopify/tests/utils.py 98.07% <ø> (ø)
ecommerce_integrations/shopify/utils.py 42.55% <0.00%> (+1.24%) ⬆️

@rtdany10 rtdany10 marked this pull request as draft February 2, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant