Skip to content

Commit

Permalink
Update stock_ageing.py
Browse files Browse the repository at this point in the history
As reviewer Deepesh Garg advised thanks!  batch[0] can be int of float - see line 49 - so change proposed cint to flt
  • Loading branch information
clarkejj committed Jun 12, 2020
1 parent 6b55f66 commit 677978d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions erpnext/stock/report/stock_ageing/stock_ageing.py
Expand Up @@ -180,14 +180,14 @@ def get_fifo_queue(filters, sle=None):
qty_to_pop = abs(d.actual_qty)
while qty_to_pop:
batch = fifo_queue[0] if fifo_queue else [0, None]
if 0 < cint(batch[0]) <= qty_to_pop:
if 0 < flt(batch[0]) <= qty_to_pop:
# if batch qty > 0
# not enough or exactly same qty in current batch, clear batch
qty_to_pop -= cint(batch[0])
qty_to_pop -= flt(batch[0])
transferred_item_details[(d.voucher_no, d.name)].append(fifo_queue.pop(0))
else:
# all from current batch
cint(batch[0]) -= qty_to_pop
flt(batch[0]) -= qty_to_pop
transferred_item_details[(d.voucher_no, d.name)].append([qty_to_pop, batch[1]])
qty_to_pop = 0

Expand Down

0 comments on commit 677978d

Please sign in to comment.