fix(Employee Advance): check if return amount is set before validating (

#36080)
frappe · Jul 11, 2023 · beaf13e · beaf13e
1 parent 9c3ec41
commit beaf13e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/erpnext/hr/doctype/employee_advance/employee_advance.py b/erpnext/hr/doctype/employee_advance/employee_advance.py
@@ -108,8 +108,8 @@ def set_total_advance_paid(self):
 				EmployeeAdvanceOverPayment,
 			)
 
-		if flt(return_amount) > self.paid_amount - self.claimed_amount:
-			frappe.throw(_("Return amount cannot be greater unclaimed amount"))
+		if flt(return_amount) > 0 and flt(return_amount) > (self.paid_amount - self.claimed_amount):
+			frappe.throw(_("Return amount cannot be greater than unclaimed amount"))
 
 		self.db_set("paid_amount", paid_amount)
 		self.db_set("return_amount", return_amount)