Skip to content

Commit

Permalink
Merge pull request #31816 from nabinhait/crm-no-of-employees
Browse files Browse the repository at this point in the history
fix: limited options for no-of-employees in the crm documents
  • Loading branch information
nabinhait committed Aug 9, 2022
2 parents 08d7c48 + 909945c commit eb25edd
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 8 deletions.
6 changes: 3 additions & 3 deletions erpnext/crm/doctype/lead/lead.json
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,8 @@
"fieldname": "no_of_employees",
"fieldtype": "Select",
"label": "No of Employees",
"options": "1-10\n11-20\n21-30\n31-100\n11-50\n51-200\n201-500\n101-500\n500-1000\n501-1000\n>1000\n1000+"
},
"options": "1-10\n11-50\n51-200\n201-500\n501-1000\n1000+"
},
{
"fieldname": "column_break_22",
"fieldtype": "Column Break"
Expand Down Expand Up @@ -514,7 +514,7 @@
"idx": 5,
"image_field": "image",
"links": [],
"modified": "2022-07-22 15:55:03.176094",
"modified": "2022-08-09 18:26:17.101521",
"modified_by": "Administrator",
"module": "CRM",
"name": "Lead",
Expand Down
4 changes: 2 additions & 2 deletions erpnext/crm/doctype/opportunity/opportunity.json
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@
"fieldname": "no_of_employees",
"fieldtype": "Select",
"label": "No of Employees",
"options": "1-10\n11-20\n21-30\n31-100\n11-50\n51-200\n201-500\n101-500\n500-1000\n501-1000\n>1000\n1000+"
"options": "1-10\n11-50\n51-200\n201-500\n501-1000\n1000+"
},
{
"fieldname": "annual_revenue",
Expand Down Expand Up @@ -622,7 +622,7 @@
"icon": "fa fa-info-sign",
"idx": 195,
"links": [],
"modified": "2022-07-22 18:46:32.858696",
"modified": "2022-08-09 18:26:37.235964",
"modified_by": "Administrator",
"module": "CRM",
"name": "Opportunity",
Expand Down
4 changes: 2 additions & 2 deletions erpnext/crm/doctype/prospect/prospect.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"fieldname": "no_of_employees",
"fieldtype": "Select",
"label": "No. of Employees",
"options": "1-10\n11-20\n21-30\n31-100\n11-50\n51-200\n201-500\n101-500\n500-1000\n501-1000\n>1000\n1000+"
"options": "1-10\n11-50\n51-200\n201-500\n501-1000\n1000+"
},
{
"fieldname": "annual_revenue",
Expand Down Expand Up @@ -218,7 +218,7 @@
],
"index_web_pages_for_search": 1,
"links": [],
"modified": "2022-06-22 15:10:26.887502",
"modified": "2022-08-09 18:26:56.950185",
"modified_by": "Administrator",
"module": "CRM",
"name": "Prospect",
Expand Down
3 changes: 2 additions & 1 deletion erpnext/patches.txt
Original file line number Diff line number Diff line change
Expand Up @@ -309,4 +309,5 @@ erpnext.patches.v14_0.migrate_gl_to_payment_ledger
erpnext.patches.v14_0.crm_ux_cleanup
erpnext.patches.v14_0.remove_india_localisation # 14-07-2022
erpnext.patches.v13_0.fix_number_and_frequency_for_monthly_depreciation
erpnext.patches.v14_0.remove_hr_and_payroll_modules # 20-07-2022
erpnext.patches.v14_0.remove_hr_and_payroll_modules # 20-07-2022
erpnext.patches.v14_0.fix_crm_no_of_employees
26 changes: 26 additions & 0 deletions erpnext/patches/v14_0/fix_crm_no_of_employees.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import frappe


def execute():
options = {
"11-20": "11-50",
"21-30": "11-50",
"31-100": "51-200",
"101-500": "201-500",
"500-1000": "501-1000",
">1000": "1000+",
}

for doctype in ("Lead", "Opportunity", "Prospect"):
frappe.reload_doctype(doctype)
for key, value in options.items():
frappe.db.sql(
"""
update `tab{doctype}`
set no_of_employees = %s
where no_of_employees = %s
""".format(
doctype=doctype
),
(value, key),
)

0 comments on commit eb25edd

Please sign in to comment.