Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Journal entry from Invoice based on Payment Terms (due date) #11989

Closed
nabinhait opened this issue Dec 13, 2017 · 1 comment · Fixed by #12047
Closed

Make Journal entry from Invoice based on Payment Terms (due date) #11989

nabinhait opened this issue Dec 13, 2017 · 1 comment · Fixed by #12047
Assignees
@tundebabzy
Labels
bug
Milestone
Version 10

Comments

@nabinhait
Copy link
Member

While making Journal Entry from Sales/Purchase Invoice, add multiple rows in Journal Entry based on due dates.
@nabinhait nabinhait added this to the Version 10 milestone Dec 13, 2017
@nabinhait nabinhait added the bug label Dec 13, 2017
@tundebabzy tundebabzy self-assigned this Dec 13, 2017
@tundebabzy tundebabzy mentioned this issue Dec 14, 2017
Merged
nabinhait pushed a commit that referenced this issue Dec 15, 2017
@tundebabzy @nabinhait
Make Journal entry from Invoice based on Payment Terms (due date) #11989
1d459c4 
 (#12019)

* don"t summarise due_dates query

* reference_due_date to fetch outstanding based on due date

* use if else so that no need to do useless checks

* clear debit and credit fields before fetching outstanding

* grid keeps forgetting drop down so add to options

* clear debit and credit fields before fetching outstanding properly
@nabinhait nabinhait reopened this Dec 15, 2017
@nabinhait
Copy link
Member Author

nabinhait commented Dec 15, 2017 •
edited
Loading

@tundebabzy The fix #12019 is good, but it solves another bug which I actually did not report.

The bug I reported is when we make payment entry using "Make Payment" from inside Sales invoice form, it does not add multiple rows in Journal Entry based on payment schedule. To replicate this issue, you need to enable "Make Payment via Journal Entry" from Accounts Settings.

invoice_payment

@tundebabzy tundebabzy mentioned this issue Dec 15, 2017
Merged
nabinhait pushed a commit that referenced this issue Dec 19, 2017
@tundebabzy @nabinhait
Make Journal entry from Invoice based on Payment Terms (due date) #11989
90076bc 
 (#12047)

* split journal entry according to invoice due date

* fix bug where reference_due_dates options are not populated:
- after making JE, add options to _onload
- use __onload to add options

* cater for case where no payment_schedule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tundebabzy tundebabzy

Labels
bug
Projects
None yet
Milestone
Version 10
Development

Successfully merging a pull request may close this issue.

Make Journal entry from Invoice based on Payment Terms (due date) #11989 tundebabzy/erpnext
2 participants
@tundebabzy @nabinhait