Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Exchange Rate Is Fetched When Exchange Rate Is Different From Company Currency For Price Lists #12712

Closed
tundebabzy opened this issue Jan 30, 2018 · 1 comment
Closed

Wrong Exchange Rate Is Fetched When Exchange Rate Is Different From Company Currency For Price Lists #12712

tundebabzy opened this issue Jan 30, 2018 · 1 comment
Assignees
@tundebabzy
Labels
bug

Comments

@tundebabzy
Copy link
Contributor

To be specific, when currency is equal to price list company, price list currency is set as 1 even if currency and price list currency are different from the company currency

peek 2018-01-30 13-45
@tundebabzy tundebabzy added the bug label Jan 30, 2018
@tundebabzy tundebabzy self-assigned this Jan 30, 2018
@tundebabzy tundebabzy mentioned this issue Jan 30, 2018
Merged
@tundebabzy
Copy link
Contributor Author

Fixed in #12714

nabinhait pushed a commit that referenced this issue Feb 12, 2018
@tundebabzy @nabinhait
Wrong Exchange Rate Is Fetched When Exchange Rate Is Different From C…
6e90f49 
…ompany Currency For Price Lists #12712 (#12714)

* unconditionally fetch exchange rate

* Revert "unconditionally fetch exchange rate"

This reverts commit d0d404d.

* allow for `plc_conversion_rate` field to be reset

* fetch exchange rate using price list currency and company currency not form currency

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tundebabzy tundebabzy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tundebabzy