Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Issue - Piling of list #2592

Closed
neilLasrado opened this issue Jan 16, 2015 · 11 comments
Closed

Batch Issue - Piling of list #2592

neilLasrado opened this issue Jan 16, 2015 · 11 comments

Comments

@neilLasrado
Copy link
Contributor

in forms where batch is used as a link field. the list of batch numbers that appear in the drop down are sorted based on time of creation ( LIFO ) . It must rather be based on expiry date. So the ones expiring
first are shown first and then the later batches.

Taken from Mehul B. Mehta from Mehta Herbs and Spices via Support Ticket Number #WN-SUP10808

@RealDesignGraphics
Copy link

I agree

@sbkolate
Copy link
Contributor

With small modification in get_batch_no query we can sort batch with expiry

batch sorted

@RealDesignGraphics
Copy link

where is that screen shot from?

@sbkolate
Copy link
Contributor

This is from Delivery Note
Above screen shot shows, Batch No. sorted based on expiry date. So the ones expiring
first are shown first and then the later batches.

batch_qty

Updated screen shot shows available batch qty at warehouse

Please see this:

https://discuss.frappe.io/t/available-batch-qty-at-warehouse-in-dn-si-and-batch-sorted-based-on-expiry-date/5021

@RealDesignGraphics
Copy link

I guess I mean from what screen would I see this? from the stock module? or from sales? I assume it is from the new version

@sbkolate
Copy link
Contributor

Currently this is in developing mode.
If this merge with v4 you can see result like this is Delivery Note and Sales Invoice.

@rmehta
Copy link
Member

rmehta commented Mar 10, 2015

@sbkolate pull request please !

@rmehta
Copy link
Member

rmehta commented Mar 10, 2015

Lets do v5 only.

@rmehta rmehta closed this as completed Mar 10, 2015
@rmehta rmehta reopened this Mar 10, 2015
@sbkolate
Copy link
Contributor

I have allready send pull request for v4.

I will also send pull request for v5.

@nabinhait
Copy link
Member

@sbkolate Thanks for the PR, merged it. No need to send PR for v5, I will merge it in v5.

Can you please send a pull request for get_batch_no query to sort batch with expiry?

@cgpurbaugh
Copy link
Contributor

Can this be closed?

@rmehta rmehta closed this as completed Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants