Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update get_batch_no query to sort batch with expiry date #2949

Merged
merged 1 commit into from
Mar 18, 2015
Merged

update get_batch_no query to sort batch with expiry date #2949

merged 1 commit into from
Mar 18, 2015

Conversation

sbkolate
Copy link
Contributor

with reference to #2592

I have updated get_batch_no query,

  1. Batch Id is sorted with expiry date
  2. actual stock quantity and stock_uom for that warehouse is also shown in drop down.
  3. I have done some more changes.
    Batch ID
    actual_batch_qty,stock_uom
    expirary_date
    In my case it will show,
    RN - A
    75.0,Drum, 2015-03-13

I have tried my best to keep result generic and useful for every industry.

If you want to more improvement, all suggestion are welcome.
This will helpful to take quick decision

  1. I have also added small fix to my previous pull request Added Actual Batch Qty for item in DN & SI #2942
    If we select batch number before selecting item_code. it will give error message get_batch_qty takes 3 argument you given 1.

New fix will avoid this error message and shows "Please enter Item Code to get batch no"
Thanks for accepting my last request. I am really learning clean coding from you, which is very helpful for me.

Thanks,
Sambhaji

small fix to avoid error msg if item_code not selected and batch_no is entered
nabinhait added a commit that referenced this pull request Mar 18, 2015
update get_batch_no query to sort batch with expiry date
@nabinhait nabinhait merged commit 87ee502 into frappe:develop Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants