Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting translations containing curly brackets causes JSONDecodeError #26381

Closed
dabruh opened this issue Jul 8, 2021 · 2 comments
Closed

Comments

@dabruh
Copy link

dabruh commented Jul 8, 2021

Description of the issue

Submitting translations containing curly brackets causes JSONDecodeError

Context information (for bug reports)

Output of bench version

??

Steps to reproduce the issue

  1. Submit a translated text containing e.g. {0}.

Observed result

JSONDecodeError

Expected result

Successful submission.

Stacktrace / full error message

Unable to get that now. I have a feeling I've crashed the translation endpoint as it's now refusing connections.

Additional information

Running Frappe Docker

ERPNEXT_VERSION=v13.6.0
FRAPPE_VERSION=v13.6.0
@dabruh dabruh added the bug label Jul 8, 2021
@dabruh
Copy link
Author

dabruh commented Jul 9, 2021

I just tried to submit translations now that the translation endpoint is back online, but the translation tool bugged out during submission... This time it didn't even contain any curly brackets...

Screenshot 2021-07-09 at 12-48-18 Translation Tool

Screenshot 2021-07-09 at 12-47-41 Translation Tool

It's the 3rd time I try to submit this and it is kinda tiring, so please enter this in yourselves. Translations are for Swedish:

EN: Party
SV: Part

EN: Party Name
SV: Namn på part

EN: Party Type
SV: Parttyp

EN: Party Type and Party is mandatory for {0} account
SV: Parttyp och part är obligatorisk för {0} konto

EN: Billing currency must be equal to either default company's currency or party account currency
SV: Faktureringsvalutan måste vara densamma som antingen standardföretagets valuta eller partens valuta

EN: Group by Party
SV: Gruppera efter part

EN: Party Type is mandatory
SV: Parttyp måste anges

EN: Party is mandatory
SV: Part måste anges

EN: Please select Party Type first
SV: Välj parttyp först

EN: Processing Party Addresses
SV: Bearbetar partadresser

EN: Row {0}: Party / Account does not match with {1} / {2} in {3} {4}
SV: Rad {0}: Part / konto stämmer inte överens med {1} / {2} i {3} {4}

EN: Row {0}: Party Type and Party is required for Receivable / Payable account {1}
SV: Rad {0}: Parttyp och part krävs för kundfordringskonto / leverantörsskuldkonto {1}

EN: To filter based on Party, select Party Type first
SV: Välj parttyp först, för att filtrera på part

EN: Third Party Authentication
SV: Tredjepartsautentisering

EN: Party Details
SV: Partinformation

EN: Party Balance
SV: Balans för part

EN: Create Missing Party
SV: Skapa saknad part

EN: Party Account
SV: Partkonto

EN: Party Bank Account
SV: Partbankonto

EN: Party Information
SV: Partinformation

EN: Party Account Currency
SV: Partkontovaluta

EN: Party User
SV: Partanvändare

EN: Trial Balance for Party
SV: Råbalans för part

EN: Party GSTIN
SV: Part-GSTIN

EN: Please Select Both Company and Party Type First
SV: Välj först både företags- och parttyp

EN: Party Type and Party is required for Receivable / Payable account {0}
SV: Parttyp och part krävs för kundfordringskonto / leverantörsskuldkonto {0}

@ankush ankush added the to-validate Old issues pending validation label Dec 10, 2021
@ankush ankush removed the to-validate Old issues pending validation label Jan 19, 2022
@stale
Copy link

stale bot commented Mar 20, 2022

This issue has been automatically marked as inactive because it has not had recent activity and it wasn't validated by maintainer team. It will be closed within a week if no further activity occurs.

@stale stale bot added the inactive label Mar 20, 2022
@stale stale bot closed this as completed Mar 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants