perf: cache barcode scan result #32629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #32629 +/- ##
===========================================
+ Coverage 63.68% 63.72% +0.04%
===========================================
Files 816 816
Lines 58260 58324 +64
===========================================
+ Hits 37102 37169 +67
+ Misses 21158 21155 -3
|
Is it anything? The columns are indexed so it's not like the DB query is slow. 😬
A typical scan request is completed within 3 milliseconds! |
|
Benchmarked
So it's something! Though I recon biggest time consumer here would be the latency itself, so the locality of the server matters more than anything. Can't beat speed of light 🚀 If it's for repeat scan of same items only then even better option would be limited client side caching. |
ankush
requested changes
Oct 19, 2022
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
ankush
added
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2022
* perf: cache barcode scan result * feat: BarcodeScanResult type * fix: use safe `get_value` `set_value` Co-authored-by: Ankush Menat <ankushmenat@gmail.com> (cherry picked from commit b88e850)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
# [14.4.0](v14.3.1...v14.4.0) (2022-10-26) ### Bug Fixes * Advance paid amount in orders (backport [#32642](#32642)) ([#32648](#32648)) ([8a88105](8a88105)) * allow to create Sales Order from expired Quotation ([#32641](#32641)) ([ccc58f4](ccc58f4)) * Billing Address for inter-company purchase docs ([f8934fa](f8934fa)) * BOM cost update message ([e539579](e539579)) * dont update item info twice ([8876904](8876904)) * incorrect qty in material request ([da538a3](da538a3)) * number of months subscription plan ([fff9e76](fff9e76)) * overlap error not raised for job card in case of workstation with production capacity ([ed2a093](ed2a093)) * party type and party mandatory on updating outstanding ([9a5e238](9a5e238)) * searchfield not working for cuctsomer, supplier as per customize form ([fb1c307](fb1c307)) * unset contact details ([d7a65b1](d7a65b1)) ### Features * Basic Payment Ledger report ([5cb9f7b](5cb9f7b)) * Repayment schedule types for term loans ([6ce32fd](6ce32fd)) ### Performance Improvements * cache barcode scan result (backport [#32629](#32629)) ([#32672](#32672)) ([3300856](3300856))
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally this saves ~2-5ms per scan.
Remote server: Untested.
The time saving really isn't that much, but it's something.