-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Advance paid amount in orders #32642
Merged
ankush
merged 1 commit into
frappe:develop
from
deepeshgarg007:auto_advance_allocate_from_order
Oct 19, 2022
Merged
fix: Advance paid amount in orders #32642
ankush
merged 1 commit into
frappe:develop
from
deepeshgarg007:auto_advance_allocate_from_order
Oct 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #32642 +/- ##
===========================================
- Coverage 63.99% 63.72% -0.28%
===========================================
Files 817 816 -1
Lines 58228 58310 +82
===========================================
- Hits 37264 37156 -108
- Misses 20964 21154 +190
|
ankush
approved these changes
Oct 19, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
(cherry picked from commit 4304921)
This was referenced Oct 19, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
(cherry picked from commit 4304921) # Conflicts: # erpnext/accounts/doctype/payment_entry/payment_entry.py
ankush
pushed a commit
that referenced
this pull request
Oct 19, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
# [14.4.0](v14.3.1...v14.4.0) (2022-10-26) ### Bug Fixes * Advance paid amount in orders (backport [#32642](#32642)) ([#32648](#32648)) ([8a88105](8a88105)) * allow to create Sales Order from expired Quotation ([#32641](#32641)) ([ccc58f4](ccc58f4)) * Billing Address for inter-company purchase docs ([f8934fa](f8934fa)) * BOM cost update message ([e539579](e539579)) * dont update item info twice ([8876904](8876904)) * incorrect qty in material request ([da538a3](da538a3)) * number of months subscription plan ([fff9e76](fff9e76)) * overlap error not raised for job card in case of workstation with production capacity ([ed2a093](ed2a093)) * party type and party mandatory on updating outstanding ([9a5e238](9a5e238)) * searchfield not working for cuctsomer, supplier as per customize form ([fb1c307](fb1c307)) * unset contact details ([d7a65b1](d7a65b1)) ### Features * Basic Payment Ledger report ([5cb9f7b](5cb9f7b)) * Repayment schedule types for term loans ([6ce32fd](6ce32fd)) ### Performance Improvements * cache barcode scan result (backport [#32629](#32629)) ([#32672](#32672)) ([3300856](3300856))
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two partial payment entries are made simultaneously against a single order using two separate requests, both requests try to update the Advance Paid amount simultaneously and create a race condition.
Since both the requests read the previous advance amount as 0 the amount of the request which updates the value later is only seen rather than the sum of both entries.
Added a
for_update
flag to resolve the issue