Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regional): allow regional override for updating gl_dict #35550

Merged
merged 1 commit into from Jun 4, 2023

Conversation

vorasmit
Copy link
Contributor

@vorasmit vorasmit commented Jun 4, 2023

This override can be used to update gl_dict for country-specific use cases.
eg: Company GSTIN for India

@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #35550 (2e566a2) into develop (5ebf46a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35550   +/-   ##
========================================
  Coverage    63.95%   63.95%           
========================================
  Files          812      812           
  Lines        61735    61739    +4     
========================================
+ Hits         39484    39487    +3     
- Misses       22251    22252    +1     
Impacted Files Coverage Δ
erpnext/controllers/accounts_controller.py 85.01% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit b1ef19a into frappe:develop Jun 4, 2023
14 checks passed
@vorasmit
Copy link
Contributor Author

vorasmit commented Jun 5, 2023

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2023

backport version-14-hotfix

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@vorasmit vorasmit deleted the override-gl-dict branch June 5, 2023 02:28
@vorasmit
Copy link
Contributor Author

vorasmit commented Jun 5, 2023

@deepeshgarg007 Can you please backport this?

@vorasmit vorasmit restored the override-gl-dict branch June 5, 2023 08:26
@sagarvora sagarvora added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Jun 5, 2023
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
sagarvora added a commit that referenced this pull request Jun 5, 2023
…-35550

fix(regional): allow regional override for updating gl_dict (backport #35550)
@vorasmit vorasmit deleted the override-gl-dict branch June 5, 2023 08:59
frappe-pr-bot pushed a commit that referenced this pull request Jun 7, 2023
# [14.27.0](v14.26.0...v14.27.0) (2023-06-07)

### Bug Fixes

* add validation for existing Serial No Manufactured/Received again ([#35534](#35534)) ([4ed701b](4ed701b))
* get party details ([c7391c8](c7391c8))
* higher precision makes ERR to misjudge zero bal acc as non-zero ([456c336](456c336))
* ignore `Non-Stock Item` mapping in Pick List ([200166b](200166b))
* ignore `Non-Stock Item` while calculating `% Picked` in Sales Order ([c0d8271](c0d8271))
* Interest Accrual on Loan Topup ([#35555](#35555)) ([6140f13](6140f13))
* missing bom details in the stock entry ([2ee0229](2ee0229))
* **regional:** allow regional override for updating gl_dict ([#35550](#35550)) ([57b502b](57b502b))
* Task gantt popup style ([20e2242](20e2242))
* update `Stock Reconciliation` document while reposting ([cc95ced](cc95ced))
* **ux:** throw if no row selected to create repost entries (backport [#35503](#35503)) ([#35504](#35504)) ([5ba5fb1](5ba5fb1))

### Features

* ability to create quotation against a prospect ([d82d159](d82d159))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants