Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Once primary key is generated, do not allow changing Series #8911

Closed
umairsy opened this issue May 18, 2017 · 2 comments
Closed

Once primary key is generated, do not allow changing Series #8911

umairsy opened this issue May 18, 2017 · 2 comments
Assignees
@tundebabzy
Labels
bug frappe-support
Milestone
2017-06

Comments

@umairsy
Copy link
Member

umairsy commented May 18, 2017

Raised via WN-SUP25185

Once the Sales Invoice is generated, Series field is not visible. But one can still edit value in the Series field from Report Builder, or (I suspect) from Data Import Tool as well.

If a primary key is generated for a document, then value in the Series field should freeze.
@umairsy umairsy changed the title On primary key generated, do not allow changing Series Once primary key is generated, do not allow changing Series May 18, 2017
@rmehta rmehta modified the milestone: Version 8.1 Jun 8, 2017
@tundebabzy tundebabzy mentioned this issue Jun 10, 2017
Closed
@tundebabzy
Copy link
Contributor

Hello @umairsy
Please follow progress on this issue in frappe/frappe#3460

@tundebabzy tundebabzy self-assigned this Jun 10, 2017
@tundebabzy tundebabzy mentioned this issue Jun 13, 2017
Merged
nabinhait pushed a commit that referenced this issue Jun 14, 2017
@tundebabzy @nabinhait
Once primary key is generated, do not allow changing Series #8911 (#9265
f5604c1 
)

* changes set_only_once field for tabDocField to 1

* changes all affected doctypes `set_only_once` option to 1

* add patch name to text file

* adds test cases

* Revert "add patch name to text file"

This reverts commit fc7cb6b.

* Revert "changes set_only_once field for tabDocField to 1"

This reverts commit 2b1f7f3.
@tundebabzy
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tundebabzy tundebabzy

Labels
bug frappe-support
Projects
None yet
Milestone
2017-06
Development

No branches or pull requests
3 participants
@rmehta @tundebabzy @umairsy