Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of public/private for files to be a parameter #9102

Closed
jwrober opened this issue May 31, 2017 · 6 comments
Closed

Allow setting of public/private for files to be a parameter #9102

jwrober opened this issue May 31, 2017 · 6 comments

Comments

@jwrober
Copy link
Contributor

jwrober commented May 31, 2017

From here - https://discuss.erpnext.com/t/default-file-setting-to-private/23698

Would like to have a setting of some kind to be able to set the default behavior of files. In my use case I want the default to be private. However others might want public. So having a global setting run this would be great.

@Tropicalrambler
Copy link
Contributor

This is CRITICAL.

@bcornwellmott
Copy link
Contributor

I made a PR to have the default as private, because it's a more robust condition than making things public by default. Adding a setting will probably be harder.
frappe/frappe#3521

@tundebabzy
Copy link
Contributor

Merged

@cosimot
Copy link

cosimot commented Sep 8, 2017

now it is set as public by default again.

@mmasifashraf
Copy link

its came as public by default again

@Lewinta
Copy link

Lewinta commented Sep 30, 2020

I suggest to include an option for Attach fieldtypes on Customize Forms where users can specify if this check is ready only and allow to choose a default (0 or 1)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants