Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't set Start and End Dates in Salary Slip #9513

Closed
theopen-institute opened this issue Jun 28, 2017 · 5 comments
Closed

Can't set Start and End Dates in Salary Slip #9513

theopen-institute opened this issue Jun 28, 2017 · 5 comments
Assignees
@tundebabzy
Labels
bug
Milestone
2017-07-26

Comments

@theopen-institute
Copy link

When creating new salary slips for any of my monthly employees, I am not able to set my desired Start and End Dates. No matter what I put, the Start and End dates automatically revert to the 16th and last days of whatever month I've selected (respectively).

My salary structure seems to be set correctly, and all of my employees have start dates before the current month. Something, however, is causing the dates to change as soon as I enter them.
@tundebabzy tundebabzy added to-validate Old issues pending validation bug and removed to-validate Old issues pending validation labels Jun 28, 2017
@tundebabzy tundebabzy added this to the 2017-07-05 milestone Jun 28, 2017
@tundebabzy tundebabzy self-assigned this Jun 28, 2017
@tundebabzy
Copy link
Contributor

Hi @theopen-institute ,
Does your fiscal year start on the 16th?

@theopen-institute
Copy link
Author

Thanks for taking this on @tundebabzy

Good catch, yes it does. Is that the root of the problem? Even if I were to shift my payment cycle onto 16th to 15th, I'm still not able to change the end date to anything other than the last day of the month.

@tundebabzy
Copy link
Contributor

tundebabzy commented Jun 28, 2017 •
edited

@theopen-institute

Is that the root of the problem?

Yes. The behaviour is wrong though. The start date should be exactly the same as the start date on the salary structure. I can fix this today and hopefully into will make into into production in tomorrow's release. We don't want to delay people's pay :)

@tundebabzy tundebabzy modified the milestones: 2017-06-29, 2017-07-05 Jun 28, 2017
@theopen-institute
Copy link
Author

Thanks @tundebabzy

@tundebabzy tundebabzy modified the milestones: 2017-07-05, 2017-06-29 Jun 29, 2017
@tundebabzy tundebabzy mentioned this issue Jun 29, 2017
Closed
14 tasks
@tundebabzy
Copy link
Contributor

Hello @theopen-institute
Please follow progress on this issue on #9530 .

@tundebabzy tundebabzy mentioned this issue Jun 30, 2017
Closed
@tundebabzy tundebabzy reopened this Jul 1, 2017
@tundebabzy tundebabzy mentioned this issue Jul 4, 2017
Closed
4 tasks
@rmehta rmehta modified the milestones: 2017-07-06, 2017-07-11 Jul 7, 2017
@tundebabzy tundebabzy mentioned this issue Jul 7, 2017
Closed
15 tasks
@nabinhait nabinhait modified the milestones: 2017-07-18, 2017-07-13 Jul 11, 2017
@tundebabzy tundebabzy mentioned this issue Jul 13, 2017
Closed
15 tasks
@nabinhait nabinhait modified the milestones: 2017-07-18, 2017-07-20 Jul 18, 2017
@tundebabzy tundebabzy mentioned this issue Jul 18, 2017
Merged
@rmehta rmehta modified the milestones: 2017-07-20, 2017-07-26 Jul 19, 2017
mbauskar pushed a commit that referenced this issue Jul 20, 2017
@tundebabzy @mbauskar
Can't set Start and End Dates in Salary Slip (#9513) (#9944)
11d23f8 
* remove trigger from end_date

* adds new function `get_end_date`:
- it tries to calculate the appropriate end date for a given frequency
- returns an empty string if frequency is 'biweekly'
- adds test cases

* changes logic in `set_start_end_dates`:
- if start_date is empty in form, call process_payroll.get_start_end_dates
- else, call process_payroll.get_end_date

* `get_end_date` should return a dict

* changed "biweekly" to "bimonthly"

* change the behaviour of process payroll start and end date:
- when payroll frequency is changed, change start/end date as usual
- if start date is manually changed, use the frequency to calculate the end date

* clean up

* further cleanup

* in `get_end_date`, if `frequency` isn"t given, "monthly"

* remove end_date from cscript and introduce `set_end_date`

* fix tests

* removed whitespaces
@theopen-institute theopen-institute mentioned this issue Feb 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tundebabzy tundebabzy

Labels
bug
Projects
None yet
Milestone
2017-07-26
Development

No branches or pull requests
3 participants
@rmehta @tundebabzy @nabinhait