Add Get Suppliers dialog #10025
Merged
Add Get Suppliers dialog #10025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmehta
requested changes
Jul 24, 2017
| }, | ||
| callback: function(r) { | ||
| console.log(r); | ||
| if(r.message) { |
There was a problem hiding this comment.
this code seems very similar to the earlier block. make it common!
rmehta
previously requested changes
Jul 24, 2017
| dialog.fields_dict.search_type.$input.change( function() { | ||
| var args = dialog.get_values(); | ||
| if(!args) return; | ||
| if (args.search_type === "Tag") { |
There was a problem hiding this comment.
Just use the depend_on property in the field definition above!
|
Closing for now, pls reopen |
rmehta
reviewed
Jul 25, 2017
| } | ||
| } | ||
|
|
||
| function LoadSuppliers(r) { |
rmehta
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dialog box that gets called when using the new Get Suppliers button. Adds suppliers based on tag of supplier Type.
Needs frappe/frappe#3759 to work.