Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enahance] Provision to select customer, item code while making an invoice from timesheet #10616

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Aug 31, 2017

make_invoice_from_timesheet

Fixed #9555

]
});

dialog.fields_dict.make_sales_invoice.$input.click(function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitwaghchaure ,

Instead of adding Custom button can we use Primary Button to create Sales Invoice
e.g. dialog.set_primary_action(__("Make Sales Invocie"), function() { ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@nabinhait nabinhait merged commit fd39d6b into frappe:develop Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants