[fix] Added primary action in the modal which will show on the submission in the pos #11575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitwaghchaure
force-pushed
the
pos_modal_primary_action
branch
2 times, most recently
from
f2f0e5f
to
688c5f4
Compare
rohitwaghchaure
force-pushed
the
pos_modal_primary_action
branch
from
688c5f4
to
c40fde5
Compare
|
@rmehta What do you think about this? Is the modal needed, as we already have Print and New button as a part of standard toolbar? |
|
This is another place where frappe/frappe#4203 would make sense |
vishdha
pushed a commit
to vishdha/erpnext
that referenced
this pull request
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Modal
Fixed
#11571