[feature] Shipping Rule Tax calculated based on Total Net Weight #11672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
nabinhait
requested changes
Nov 21, 2017
| "bold": 0, | ||
| "collapsible": 0, | ||
| "columns": 0, | ||
| "fieldname": "weight", |
There was a problem hiding this comment.
weight_per_unit will be more clearer
vishdha
force-pushed
the
shipping_rule_weight
branch
3 times, most recently
from
5e53339
to
54a8341
Compare
|
|
vishdha
force-pushed
the
shipping_rule_weight
branch
from
6dc4d9f
to
b48411e
Compare
| @@ -343,6 +343,9 @@ cur_frm.cscript.select_print_heading = function(doc,cdt,cdn){ | |||
| cur_frm.pformat.print_heading = __("Purchase Invoice"); | |||
| } | |||
|
|
|||
| cur_frm.add_fetch('item_code','weight_per_unit','weight_per_unit'); | |||
| cur_frm.add_fetch('item_code','weight_uom','weight_uom'); | |||
There was a problem hiding this comment.
Wrote same code in every file. Add this code into transaction.js and check child table(eg. sales order item) has field weight_per_unit
| @@ -70,6 +70,7 @@ def calculate_item_values(self): | |||
| item.net_rate = item.rate | |||
| item.amount = flt(item.rate * item.qty, item.precision("amount")) | |||
| item.net_amount = item.amount | |||
| item.total_weight = flt(item.weight_per_unit * item.qty) | |||
There was a problem hiding this comment.
Total weight will calculate only if there is taxes? I think this has to be done on qty change trigger?
| @@ -92,6 +92,7 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ | |||
| item.amount = flt(item.rate * item.qty, precision("amount", item)); | |||
| item.net_amount = item.amount; | |||
| item.item_tax_amount = 0.0; | |||
| item.total_weight = flt(item.weight_per_unit * item.qty) | |||
There was a problem hiding this comment.
Total weight calculation must be on qty trigger?
|
Duplicate #11770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Shipping Rule select calculate_based_on: Net Weight and Select condition from value to value.
In Sales Invoice Item Weight, total_weight and weight_uom field are added.
based on qty weight are calculated for eg. weight=20 and qty = 5, total_weight = 100
In Sales invoice on select shipping rule, it will calculate tax based on total_net_weight.