Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Purchase Taxes and Charges default field for category to 'Total' #11857

Merged
merged 1 commit into from Dec 6, 2017

Conversation

tundebabzy
Copy link
Contributor

Inspired from #11845
Most taxes that will go into a purchase invoice will mostly be recoverable taxes which should not be added to the Item's valuation. The default for category under Purchase Taxes and Charges is "Valuation and Total". This PR changes it to "Total" for user convenience.

@GSLabIt
Copy link

GSLabIt commented Dec 5, 2017

I think would be better to differentiate Taxes from Charges, as all Charges like shipping, logistic cost has to be added to valuation while taxes are recoverable so, as discussed, haven't to be included in valuation.

Other than that charges would be per item and per supplier, as different supplier could add different charges.

@nabinhait nabinhait merged commit 6a418f2 into frappe:hotfix Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants