[fix] #11880- Item wise report showing price list and stock available #11885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked travis errors, they do not seem to be related to this PR. This is ready for review. |
nabinhait
requested changes
Dec 8, 2017
| select | ||
| item_code as item_code, | ||
| warehouse as warehouse, | ||
| sum(actual_qty) as actual_qty |
There was a problem hiding this comment.
sum is not needed, as there will be only one bin for a combination of item and warehouse.
| stock_qty_on_hand_map = {} | ||
| for d in stock_details: | ||
| name = d["item_code"] | ||
| stock_qty_on_hand_map[name] = { |
There was a problem hiding this comment.
Here you are setting stock_details for only one random warehouse
|
Made changes and tested scenario of multiple warehouses as well
|
|
Changes made as per suggestions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing Video