Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Not able to save sales order #12851

Merged
merged 1 commit into from Feb 12, 2018

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Feb 9, 2018

Traceback (most recent call last):
  File "/home/frappe/benches/bench-2018-02-08/apps/frappe/frappe/desk/form/save.py", line 22, in savedocs
    doc.save()
  File "/home/frappe/benches/bench-2018-02-08/apps/frappe/frappe/model/document.py", line 256, in save
    return self._save(*args, **kwargs)
  File "/home/frappe/benches/bench-2018-02-08/apps/frappe/frappe/model/document.py", line 279, in _save
    self.insert()
  File "/home/frappe/benches/bench-2018-02-08/apps/frappe/frappe/model/document.py", line 218, in insert
    self.run_before_save_methods()
  File "/home/frappe/benches/bench-2018-02-08/apps/frappe/frappe/model/document.py", line 859, in run_before_save_methods
    self.run_method("validate")
  File "/home/frappe/benches/bench-2018-02-08/apps/frappe/frappe/model/document.py", line 755, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "/home/frappe/benches/bench-2018-02-08/apps/frappe/frappe/model/document.py", line 1024, in composer
    return composed(self, method, *args, **kwargs)
  File "/home/frappe/benches/bench-2018-02-08/apps/frappe/frappe/model/document.py", line 1007, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "/home/frappe/benches/bench-2018-02-08/apps/frappe/frappe/model/document.py", line 749, in <lambda>
    fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
  File "/home/frappe/benches/bench-2018-02-08/apps/erpnext/erpnext/selling/doctype/sales_order/sales_order.py", line 30, in validate
    super(SalesOrder, self).validate()
  File "/home/frappe/benches/bench-2018-02-08/apps/erpnext/erpnext/controllers/selling_controller.py", line 39, in validate
    self.validate_selling_price()
  File "/home/frappe/benches/bench-2018-02-08/apps/erpnext/erpnext/controllers/selling_controller.py", line 159, in validate_selling_price
    if flt(it.base_rate) < flt(last_purchase_rate_in_sales_uom) and not self.is_return:
AttributeError: 'SalesOrder' object has no attribute 'is_return'

@nabinhait nabinhait merged commit 45ac31a into frappe:hotfix Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants