[fix] consider user permissions in leave application calendar view #13902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinhait
requested changes
May 3, 2018
erpnext/patches.txt
Outdated
| erpnext.patches.v10_0.taxes_issue_with_pos | ||
| execute:frappe.db.set_value("HR Settings", None, "show_leaves_of_all_department_members_in_calendar", 1) |
There was a problem hiding this comment.
It will break, as HR Settings is not reloaded.
saurabh6790
force-pushed
the
match_conditions_leave_app
branch
from
26a9b78
to
51aed05
Compare
|
@nabinhait fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Showing all records though, the user permissions are applied
After
Showing records by considering user permissions
